igdb search + capped http reads: native fulltext, full-page fetch
search_games used `where name ~ "<q>"*`: prefix-only, diacritic- and word-order-sensitive -- "MARVEL Tōkon" found nothing though IGDB has it. Switch to IGDB's native `search` clause (relevance-ranked, diacritic-insensitive). fetch_url and image downloads read bodies with content.read(n), which returns only the first buffered chunk (~7 KB): pages collapsed to their <title>. httpread.read_capped collects chunks up to the byte cap; image downloads read limit+1 so over-limit files are still rejected instead of cached truncated (IMG-10). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -174,6 +174,25 @@ class TestIGDBQuery(unittest.TestCase):
|
||||
self.assertEqual(result, [{"id": 1, "name": "Super Mario Bros"}])
|
||||
|
||||
|
||||
class TestIGDBNativeSearch(unittest.TestCase):
|
||||
def test_build_query_with_search_term(self):
|
||||
"""search_games uses IGDB full-text search, not a name prefix filter."""
|
||||
query = IGDBQuery.build_query(["name"], {"game_type": "= 0"}, limit=5, search_term="Marvel Tōkon")
|
||||
self.assertEqual(query, 'search "Marvel Tōkon"; fields name; limit 5; where game_type = 0;')
|
||||
|
||||
def test_search_term_escapes_quotes_and_backslashes(self):
|
||||
query = IGDBQuery.build_query(["name"], search_term='say "hi" \\ bye')
|
||||
self.assertIn('search "say \\"hi\\" \\\\ bye";', query)
|
||||
|
||||
@patch.object(IGDBQuery, "generalized_igdb_query")
|
||||
def test_search_games_passes_search_term(self, mock_query):
|
||||
mock_query.return_value = []
|
||||
IGDBQuery("cid", "token").search_games("Elden Ring", limit=3)
|
||||
_, kwargs = mock_query.call_args
|
||||
self.assertEqual(kwargs["search_term"], "Elden Ring")
|
||||
self.assertEqual(mock_query.call_args.args[0], {})
|
||||
|
||||
|
||||
class TestIGDBTokenRefresh(unittest.TestCase):
|
||||
@staticmethod
|
||||
def _oauth_response(token="fresh_token", expires_in=5_000_000):
|
||||
|
||||
@@ -45,6 +45,45 @@ class TestIngest(unittest.TestCase):
|
||||
self.assertIsNone(cache.ingest_bytes(PNG, "chat", "alice", "1"))
|
||||
|
||||
|
||||
class TestOversizedDownloadRejected(unittest.IsolatedAsyncioTestCase):
|
||||
async def test_download_stays_over_limit_and_is_rejected(self):
|
||||
"""IMG-10: an over-limit download must be rejected, not cached truncated."""
|
||||
with tempfile.TemporaryDirectory() as tmp:
|
||||
_, cache = make_cache(tmp, {"image-max-bytes": 32})
|
||||
|
||||
class FakeContent:
|
||||
@staticmethod
|
||||
async def iter_chunked(size):
|
||||
yield PNG # 72 bytes > 32
|
||||
|
||||
class FakeResp:
|
||||
content = FakeContent()
|
||||
|
||||
async def __aenter__(self):
|
||||
return self
|
||||
|
||||
async def __aexit__(self, *a):
|
||||
return False
|
||||
|
||||
def raise_for_status(self):
|
||||
pass
|
||||
|
||||
class FakeSession:
|
||||
def get(self, url):
|
||||
return FakeResp()
|
||||
|
||||
async def __aenter__(self):
|
||||
return self
|
||||
|
||||
async def __aexit__(self, *a):
|
||||
return False
|
||||
|
||||
with patch("fjerkroa_bot.images.aiohttp.ClientSession", return_value=FakeSession()):
|
||||
data = await cache._download("http://x.com/big.png")
|
||||
self.assertEqual(len(data), 33) # limit + 1, not silently capped to limit
|
||||
self.assertIsNone(await cache.ingest_url("http://x.com/big.png", "chat", "alice", "1"))
|
||||
|
||||
|
||||
class TestVisionDataUrls(OpsBase):
|
||||
async def test_attachment_becomes_data_url(self):
|
||||
"""IMG-11: the model sees a data: URL, never the CDN link."""
|
||||
|
||||
@@ -91,6 +91,46 @@ class TestTextExtraction(unittest.TestCase):
|
||||
self.assertNotIn("x{}", text)
|
||||
|
||||
|
||||
class TestBodyReadCollectsAllChunks(unittest.IsolatedAsyncioTestCase):
|
||||
async def test_get_reads_past_first_chunk(self):
|
||||
"""URL-05 regression: body arrives in many chunks; all are collected up to the cap."""
|
||||
reader = URLReader(lambda: {}, None)
|
||||
chunks = [b"<title>t</title>", b"<p>middle</p>", b"<p>end</p>"]
|
||||
|
||||
class FakeContent:
|
||||
@staticmethod
|
||||
async def iter_chunked(size):
|
||||
for chunk in chunks:
|
||||
yield chunk
|
||||
|
||||
class FakeResp:
|
||||
status = 200
|
||||
headers = {}
|
||||
url = "http://safe.example.com"
|
||||
content = FakeContent()
|
||||
|
||||
async def __aenter__(self):
|
||||
return self
|
||||
|
||||
async def __aexit__(self, *a):
|
||||
return False
|
||||
|
||||
def raise_for_status(self):
|
||||
pass
|
||||
|
||||
class FakeSession:
|
||||
def get(self, url, allow_redirects=False):
|
||||
return FakeResp()
|
||||
|
||||
with patch("fjerkroa_bot.url_reader.guard_url", return_value=None):
|
||||
_, body = await reader._get(FakeSession(), "http://safe.example.com", 1000)
|
||||
self.assertEqual(body, b"".join(chunks))
|
||||
|
||||
with patch("fjerkroa_bot.url_reader.guard_url", return_value=None):
|
||||
_, body = await reader._get(FakeSession(), "http://safe.example.com", 20)
|
||||
self.assertEqual(body, b"".join(chunks)[:20])
|
||||
|
||||
|
||||
class TestFetchSanitizes(unittest.IsolatedAsyncioTestCase):
|
||||
async def test_fetch_result_is_sanitized_and_capped(self):
|
||||
"""URL-05: fetch output is length-capped and @everyone-neutralized."""
|
||||
|
||||
Reference in New Issue
Block a user